Implements icons for the new watchlist feature in OX #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: OX-11593
jmuscireum
reviewed
Nov 13, 2024
| @@ -125,3 +125,11 @@ | |||
| .sci-icon-magnifier-text-soft { | |||
| background-image: url(svgResource('/assets/images/icons/magnifier.svg', #212529)); | |||
| } | |||
|
|
|||
| .sci-icon-trash { | |||
| background-image: url(svgResource('/assets/images/icons/trash.svg', #53595D)); | |||
There was a problem hiding this comment.
Shouldn't this by default use the same colour as the other icons? Can you use for example opacity to make it lighter in OXOMI?
There was a problem hiding this comment.
Yes, this also doesn't seem to be a "sirius color" (its an old OX color).
Would prefer to use a color suffix appended to the class like the one above.
I think using text-soft should also be fine for the icons in the watchlist, but feel free to post a screenshot after the change. Its no problem to add additional color variants of the icons with different color suffixes.
jakobvogel
approved these changes
Nov 13, 2024
mko-sci
approved these changes
Nov 13, 2024
Fixes: OX-11593
|
Before color change: After: |
sabieber
approved these changes
Nov 13, 2024
jmuscireum
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Notes
Checklist